-
Notifications
You must be signed in to change notification settings - Fork 160
Cannot execute SignMessageLib.signMessage assembled from tx builder #556
Copy link
Copy link
Open
Description
Bug description
Environment
- Browser: Chromium
- Wallet: MetaMask
- Chain: Gnosis Chain
Steps to reproduce
- Go to the tx builder and assemble a tx with:
- address
0xd53cd0aB83D845Ac265BE939c57F53AD838012c9 - function
signMessage - message
0x68616c6c6f63
- address
- Confirm the tx with $threshold signers
- Try execute the tx (will fail)
Expected result
Executing a SignMessageLib.signMessage tx built from the tx builder ui should work.
For SignMessageLib.signMessage the tx builder should always use operation delegatecall instead of call. The latter will always fail as the library function is referring to Safe contract storage that is only available when executing the tx via delegatecall.
Obtained result
The tx builder wrongfully sets operation call for SignMessageLib.signMessage invocations and there is no ui input to manually change it to delegatecall.
Screenshots
Shows operation call wrongfully set for SignMessageLib.signMessage:
Moved from safe-global/safe-wallet-monorepo#3406
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
