Skip to content

Add OffChainSignature support to eth_signTypedData_v4 #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heri16 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add OffChainSignature support to eth_signTypedData_v4 #657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/safe-apps-provider/src/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ export class SafeAppProvider extends EventEmitter implements EIP1193Provider {

const response = await this.sdk.txs.signTypedMessage(parsedTypedData);
const signature = 'signature' in response ? response.signature : undefined;
if (!signature && 'messageHash' in response) {
// The returned signature will either be an empty string or valid one once the required number of Safe owners
// have confirmed the message.
return this.sdk.safe.getOffChainSignature(response.messageHash);
}
return signature || '0x';
}

Expand Down
Loading