Strings rework#227
Merged
Olf0 merged 51 commits intosailfishos-patches:masterfrom Jan 13, 2022
Olf0:Olf0-strings-rework
Merged
Conversation
* Omit two ";" and large string rework * Update strings for patchmanagerobject.cpp * Rework strings * Update dialog.qml section
Olf0
added
bug
Contributor
Author
|
Is there a (semi-) automatic way to check, that I did not break some strings? |
nephros
approved these changes
Jan 13, 2022
Contributor
nephros
left a comment
nephros
left a comment
There was a problem hiding this comment.
Wow, nice.
Looking forward to the next wave of translation merge requests!
Contributor
Author
This is automatically triggered now. Still I have to go through the README to adapt it to the new wording … some day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt strings to nomenclature at https://github.com/sailfishos-patches/patchmanager/wiki/Terms-and-wording
Also fix largely broken SettingsPage.qml section in settings-patchmanager.ts: Many incorrect line numbers and some missing entries.