Skip to content

Spec: modify description, add chum metadata#231

Merged
nephros merged 4 commits intosailfishos-patches:masterfrom
nephros:chum
Jan 15, 2022
Merged

Spec: modify description, add chum metadata#231
nephros merged 4 commits intosailfishos-patches:masterfrom
nephros:chum

Conversation

@nephros
Copy link
Contributor

@nephros nephros commented Jan 13, 2022

@Olf0
Copy link
Contributor

Olf0 commented Jan 14, 2022

This is looking fine, although starting the Summary line with a lowercase letter looks very unusual to me. Is this required or advised somewhere?

You can also try including the extant icon, maybe QML icon is able to render it (modern browsers are not):

…
Custom:
  Repo: https://github.com/…
Icon: https://raw.githubusercontent.com/sailfishos-patches/patchmanager/master/src/icons/svgs/icon-m-patchmanager2.svg`
…

BTW, including an raw.githubusercontent.com/ (similarly at Gitlab) link is crucial, as Rinigus tried to point out. Some of your packages at GitLab still throw errors (see point vii.), because they do use "non-raw" links to icons:

[W] unknown:17 - file:///usr/share/sailfishos-chum-gui/qml/components/PackagesListItem.qml:17:5: QML Image: Error decoding: https://gitlab.com/nephros/harbour-imagemagick/-/blob/obs/files/icon-imagemagick_sfos_256.png: Unsupported image format
[W] unknown:17 - file:///usr/share/sailfishos-chum-gui/qml/components/PackagesListItem.qml:17:5: QML Image: Error decoding: https://gitlab.com/nephros/openrepos-nethogs/-/blob/obs/rpm/nethogs_512.png: Unsupported image format
[W] unknown:17 - file:///usr/share/sailfishos-chum-gui/qml/components/PackagesListItem.qml:17:5: QML Image: Error decoding: https://gitlab.com/nephros/openrepos-nload/-/blob/obs/rpm/nload_512.png: Unsupported image format

IIRC there is a way, but by clicking around at GitLab I failed to find it (would need to read documentation or search the Web).

Copy link
Contributor

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest to adapt these changes to the current wording style:

Summary: manages Patches for SailfishOS

and

%description
Patchmanager is a tool for transparently modifying installed files by the patch
utility and for managing the special Patches for doing so.  Since version 3.0
it does not modify original files, but alters their content when they are loaded
into RAM to be run.

P.S.: I intended to commit to an own branch in my repository, but failed to. Then I thought, "WTF, lets try straight ahead" and expected that to fail and it looked like it. But now I see that I successfully committed that in your branch (and realise my syntax error, before). Feel free to revert it, if you do not like it, it was rather "wild clicking late at night in frustration".

@nephros
Copy link
Contributor Author

nephros commented Jan 14, 2022

This is looking fine, although starting the Summary line with a lowercase letter looks very unusual to me. Is this required or advised somewhere?

No, just mentioning (repeating) the package name is complained about by RPMlint.

You can also try including the extant icon, maybe QML icon is able to render it (modern browsers are not):

…
Custom:
  Repo: https://github.com/…
Icon: https://raw.githubusercontent.com/sailfishos-patches/patchmanager/master/src/icons/svgs/icon-m-patchmanager2.svg`

The link style is straight from the Chum Wiki example - should work in chum-gui. But I'll switch it to ./src/plugin/icon-m-patchmanager.png anyway.

BTW, including an raw.githubusercontent.com/ (similarly at Gitlab) link is crucial, as Rinigus tried to point out. Some of your packages at GitLab still throw errors (see point vii.), because they do use "non-raw" links to icons:

I am aware, but there's only so much time - also I want to spare the chum guys from too many trivial reqests to approve. It will come.

IIRC there is a way, but by clicking around at GitLab I failed to find it (would need to read documentation or search the Web).

There's a "raw" button when viewing binary (or rather any type of) files. EDIT: Well, used to be, seems to be gone now.

@nephros
Copy link
Contributor Author

nephros commented Jan 14, 2022

May I suggest to adapt these changes to the current wording style:

Summary: manages Patches for SailfishOS

and

%description
Patchmanager is a tool for transparently modifying installed files by the patch
utility and for managing the special Patches for doing so.  Since version 3.0
it does not modify original files, but alters their content when they are loaded
into RAM to be run.

Fine!
BTW that text is straight from the Openrepos page, so may be you want to update it there as well.

P.S.: I intended to commit to an own branch in my repository, but failed to. Then I thought, "WTF, lets try straight ahead" and expected that to fail and it looked like it. But now I see that I successfully committed that in your branch (and realise my syntax error, before). Feel free to revert it, if you do not like it, it was rather "wild clicking late at night in frustration".

"Allow updates by maintainers" magic!

@nephros nephros requested a review from Olf0 January 14, 2022 08:44
@nephros
Copy link
Contributor Author

nephros commented Jan 14, 2022

In (maybe) closing, thank you Olf for your very thourough review (here and elsewhere).

Copy link
Contributor

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine!

@Olf0
Copy link
Contributor

Olf0 commented Jan 14, 2022

Fine! BTW that text is straight from the Openrepos page, so may be you want to update it there as well.

Ah, that is why they felt so familiar. 😉

P.S.: I intended to commit to an own branch in my repository, but failed to. Then I thought, "WTF, lets try straight ahead" and expected that to fail and it looked like it. But now I see that I successfully committed that in your branch (and realise my syntax error, before). Feel free to revert it, if you do not like it, it was rather "wild clicking late at night in frustration".

"Allow updates by maintainers" magic!

Yeah, but for the next non-trivial review-changes I will try again to suggest changes in a branch in my repo, instead of committing directly to yours (even if I am allowed to).

@nephros nephros merged commit f089539 into sailfishos-patches:master Jan 15, 2022
@nephros nephros deleted the chum branch January 15, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants