Spec: modify description, add chum metadata#231
Spec: modify description, add chum metadata#231nephros merged 4 commits intosailfishos-patches:masterfrom
Conversation
|
This is looking fine, although starting the You can also try including the extant icon, maybe BTW, including an IIRC there is a way, but by clicking around at GitLab I failed to find it (would need to read documentation or search the Web). |
There was a problem hiding this comment.
May I suggest to adapt these changes to the current wording style:
Summary: manages Patches for SailfishOS
and
%description
Patchmanager is a tool for transparently modifying installed files by the patch
utility and for managing the special Patches for doing so. Since version 3.0
it does not modify original files, but alters their content when they are loaded
into RAM to be run.
P.S.: I intended to commit to an own branch in my repository, but failed to. Then I thought, "WTF, lets try straight ahead" and expected that to fail and it looked like it. But now I see that I successfully committed that in your branch (and realise my syntax error, before). Feel free to revert it, if you do not like it, it was rather "wild clicking late at night in frustration".
No, just mentioning (repeating) the package name is complained about by RPMlint.
The link style is straight from the Chum Wiki example - should work in chum-gui. But I'll switch it to ./src/plugin/icon-m-patchmanager.png anyway.
I am aware, but there's only so much time - also I want to spare the chum guys from too many trivial reqests to approve. It will come.
There's a "raw" button when viewing binary (or rather any type of) files. EDIT: Well, used to be, seems to be gone now. |
Fine!
"Allow updates by maintainers" magic! |
|
In (maybe) closing, thank you Olf for your very thourough review (here and elsewhere). |
Ah, that is why they felt so familiar. 😉
Yeah, but for the next non-trivial review-changes I will try again to suggest changes in a branch in my repo, instead of committing directly to yours (even if I am allowed to). |
See https://forum.sailfishos.org/t/announcing-sailfishos-chum-gui-0-3/9839/29 and https://github.com/sailfishos-chum/main/blob/main/Metadata.md for the chum metadata information.