Skip to content

Fix no-notification logic#281

Merged
nephros merged 1 commit intosailfishos-patches:masterfrom
nephros:issue-275
Feb 26, 2022
Merged

Fix no-notification logic#281
nephros merged 1 commit intosailfishos-patches:masterfrom
nephros:issue-275

Conversation

@nephros
Copy link
Contributor

@nephros nephros commented Feb 25, 2022

Closes: #275

@Olf0
Copy link
Contributor

Olf0 commented Feb 25, 2022

I would have assumed this to be equivalent (before and after the change), apparently you thought so, too. I only wonder, why similar constructs at other places seem to work fine.
By the help of your explanation I understood the logic error easily: Once seen, "it jumps into ones face". Thank you!

At least I understand now, why this was not in PM ≤ 3.2.0, only in 3.2.1: It was introduced 14 December 2021 and we made only this single release since then.

@nephros nephros merged commit 5828931 into sailfishos-patches:master Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Always shows "Failed" popup even if successful

2 participants