Allow re-installation of installed patches from Web Catalog page

[nephros]

This relaxes/enhances the "can it be installed" checks in the Web Catalog Patch page so installed patches can be installed again.

Use case: lazy patch developers like myself don't bump the patch version when updating OS Compatibility. This results in (old) installed patches shown in red in the main patch list.
Having the possibility to re-install updates the metadata (at the least), making the red 'incompatible' color go away.

... and a bit of trojan horse commit: highlight the compatible OS version in the "compatible" list.

[Olf0]

Sorry for the delayed review, I have been away on a holiday.

1. The code changes of the first commit (830a87a) look fine. But …

   • … please keep the wording consistent of the extant line 341 and the new line 343. I deliberately used "install", because while the remorse timer is running, nothing has happened yet. Using "installing" in this case may be misinterpreted as some kind of a countdown bar ("negative progress bar"), finishing when the bar is at zero. In reality the action only starts when the bar arrived at zero.
     Hence I suggest changing the string "Re-Installing Patch %1" in line 343 to "Re-Install Patch %1". _{If you think I am wrong, then please consider altering the string "Install Patch %1" in line 341 to "Installing Patch %1".}

   • Unrelated to these changes I wonder about the closing bracket (" ) ") in line 363: I fail to find the corresponding opening bracket (" ( "). Is this really correct?
     _{I assume either the opening bracket is missing or the closing bracket ought to be deleted.}

     The logic of the whole section looks a bit dubious to me: Why is the case !ok tested within the function(ok)? But likely I am wrong, because QML code always looks strange for me.

2. Due to my lack of QML and Qt know-how I am unable to properly review the second commit (0afc2c8) and can only tell that it formally looks fine (no obvious typos etc.). But due to you exhibiting extensive know-how of formatting and styles in Install History, I fully trust you doing the right thing. Still, please re-review your commit 0afc2c8, now that two weeks have passed.

HTH & Cheers!

[nephros]

I have changed the wording for the sake of constistency.

Jolla's recommendation is also alomg those lines.

https://sailfishos.org/develop/docs/silica/qml-sailfishsilica-sailfish-silica-remorse.html/

[nephros]

The closing brace closes the watchCall from line 352, the whole code block is actually a set of arguments to that call.

one of the arguments is an anonymous callback function (function(foo) {...}) which takes one argument (the result of the watchCall execution).

The argument can be named anything, here we name it ok, and check its value in the function body.

I agree it all looks a bit convoluted, but it's just the way asynchronous calls are done in qml/javascript.
As it's async, you can't just handle the result of the call directly, instead you give it a function to execute whenever it returns.

It's usually call( input arguments for the call, callback function on success, callback function on error).