Fix issue #325: compiler warnings#328
Merged
nephros merged 2 commits intosailfishos-patches:masterfrom Jan 5, 2023
Merged
Conversation
added 2 commits
January 5, 2023 16:48
avoid unused-result warning Contributes-To: sailfishos-patches#325
move functions under #ifdef to avoid unused-parameter and unused-function warnings. Contributes-To: sailfishos-patches#325
b100dian
approved these changes
Jan 5, 2023
Contributor
b100dian
left a comment
b100dian
left a comment
There was a problem hiding this comment.
Looks good, thanks for taking care of this!
Olf0
changed the title
Olf0
approved these changes
Jan 5, 2023
Contributor
Olf0
left a comment
Olf0
left a comment
There was a problem hiding this comment.
LGTM (It is C, not C++, hence my opinion is more profound.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid
-Wunused-result,-Wunused-function, and-Wunused-parameterwarnings.@b100dian should be non-critical, but as as the preload library has the potential to really cause a bad day for users, please review carefully.
P.S.: Fixes issue #325