Skip to content

[spec file] Insert dummy changelog with a correct entry #395

Merged
Olf0 merged 3 commits intomasterfrom
Olf0-patch-1
Jan 29, 2023
Merged

[spec file] Insert dummy changelog with a correct entry #395
Olf0 merged 3 commits intomasterfrom
Olf0-patch-1

Conversation

@Olf0
Copy link
Contributor

@Olf0 Olf0 commented Jan 23, 2023

… to calm down some versions / configurations of rpmlint: Missing %changelog section or file is punished with an error, an inconsistent version number only with a warning.

  • Update homepages to OpenRepos pages (looks more representative)

  • Post release version increase

… to calm down some versions / configurations of `rpmlint`: Missing `%changelog` section or file is punished with an error, an inconsistent version number only with a warning.

- Update homepages to OpenRepos pages (looks more representative)

- Post release version increase
@Olf0 Olf0 added the enhancement this improves something label Jan 23, 2023
@Olf0 Olf0 self-assigned this Jan 23, 2023
@Olf0 Olf0 changed the title Insert dummy changelog with a correct entry [spec file] Insert dummy changelog with a correct entry Jan 23, 2023
@nephros
Copy link
Contributor

nephros commented Jan 24, 2023

currently, rpm -q --changelog patchmanager does show a nice changelog generated from git.

Will it still have that after this change?

@Olf0 Olf0 marked this pull request as draft January 24, 2023 16:56
@Olf0
Copy link
Contributor Author

Olf0 commented Jan 24, 2023

currently, rpm -q --changelog patchmanager does show a nice changelog generated from git.

Will it still have that after this change?

Likely not. EDIT: They often become even better!
You pointed at the mechanism which seems to go wrong at the SailfishOS-OBS (somehow extracting the changelog), which I wanted to research for some time.

But as other things do have higher priorities, I am deferring this topic and setting this PR into draft status. *EDIT: … and back out of it.

TBE (to be evaluated) more thoroughly.

@Olf0 Olf0 removed the enhancement this improves something label Jan 24, 2023
@Olf0 Olf0 added the enhancement this improves something label Jan 27, 2023
@Olf0 Olf0 marked this pull request as ready for review January 27, 2023 00:20
@Olf0
Copy link
Contributor Author

Olf0 commented Jan 27, 2023

See also issue #327 (comment).
⇒ Back into "awaiting review" state

@Olf0 Olf0 merged commit bf26ee7 into master Jan 29, 2023
@Olf0 Olf0 deleted the Olf0-patch-1 branch January 29, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement this improves something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants