Add version info output#407
Merged
nephros merged 4 commits intosailfishos-patches:masterfrom Feb 1, 2023
Merged
Conversation
… consistent with dummy version in dummy changelog
Contributor
|
So calling |
Olf0
approved these changes
Feb 1, 2023
Contributor
There was a problem hiding this comment.
I hope my change of wording makes sense: I always avoid a "v" indicating a version number, if it directly follows the product name. E.g., Patchmanager 3 instead of Patchmanager v3. In also think it makes sense to capitalise Patchmanager in the header, where the term is a title and product name; in contrast to the body, where it has to be spelled as it is called at the command line.
Approving, but posed a single checks and balance question. You may simply answer "Yes" and merge, or "No" and alter the code.
Contributor
Author
Sorry, took me a while to understand the question, and you're right, I shall add it back. |
Olf0
reviewed
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple one.
Add version info to console (help) output. Just because sometimes it's useful to check.