Indicate presence of a Settings page#411
Conversation
... may or may not make it more readable ;) before it was *roughly* functionally grouped.
|
the first commit may seem confusing but it just makes the order of elements more readable (to me). |
|
Ugh, lots of changes in QML code even if they are partially repetitive. Hence I rather ask @b100dian to review this. P.S.: BTW @nephros, I posed a hidden, open question WRT a potentially stale branch for the unmerged and closed PR #410, which was superseded by PR #409. |
|
Screenshot of the change:
The text will be "tap to configure" while the patch is applied/activated, and "tap to show configuration" when it is not. That's all, the rest is just some cleanups. |
|
Hey @nephros, I never doubt that you did that (or anything else) with due diligence and in fact your screenshot is looking really good. I now took a closer look at the real changes in commit f582439 (i.e., sans the shuffling in commit 67207b1) and they appear to be fine to me. Still I only can check for obvious typos and syntax / formatting errors, but little beyond that: Subtle logical flaws will likely escape my perception when reading QML code. So I can approve this if you think it is pressing, but still would appreciate if @b100dian does that. |
| Label { | ||
| text: name | ||
| color: patchObject.details.isCompatible ? background.down ? Theme.highlightColor : Theme.primaryColor | ||
| : background.down ? Qt.tint(Theme.highlightColor, "red") : Qt.tint(Theme.primaryColor, "red") |
There was a problem hiding this comment.
(unrelated) wondering if we should use some alpha on this color tinting
There was a problem hiding this comment.
Heh you're right, this looks like it doesn't actually "tint" at all, it just results in red.
Also we might just change to Theme.errorColor, which has always been red but might change at some point.
3 participants
some patches come with a settings page.
users often are not aware, so lets add a hint