Skip to content

Add comment WRT values for the Group field#433

Merged
Olf0 merged 2 commits intomasterfrom
Olf0-patch-1
May 3, 2023
Merged

Add comment WRT values for the Group field#433
Olf0 merged 2 commits intomasterfrom
Olf0-patch-1

Conversation

@Olf0
Copy link
Contributor

@Olf0 Olf0 commented May 1, 2023

Never saw a reference, so document it now.

Never saw a reference, so document it now.
@Olf0 Olf0 self-assigned this May 1, 2023
@Olf0 Olf0 added enhancement this improves something documentation documentation, Wiki and related labels May 1, 2023
@nephros
Copy link
Contributor

nephros commented May 2, 2023

The Group tag is mandatory if the spectacle tool is used via a .yaml file, as spectacle wants it to be filled with a value from that list.

As we don't use spectacle (and Group is optional from an RPM point of view) we might as well remove that Tag completely. (Qt/Qt isn't a very valuable entry anyway.)

@Olf0
Copy link
Contributor Author

Olf0 commented May 3, 2023

The Group tag is mandatory if the spectacle tool is used via a .yaml file, as spectacle wants it to be filled with a value from that list.

Ack.

As we don't use spectacle (and Group is optional from an RPM point of view) we might as well remove that Tag completely. (Qt/Qt isn't a very valuable entry anyway.)

O.K.
I simply intended to document where valid values can be found, so one can pick an more appropriate Group tag later.

I have no idea if anything else but Spectacle evaluates the Group tag; if you are sure that nothing else does, I am fine with removing it.

P.S.: The Group: Qt/Qt statement seems to be something which was copied to almost all SFOS applications.

@Olf0
Copy link
Contributor Author

Olf0 commented May 3, 2023

Looking at the list, I think that both Applications/System and System/System Control (but nothing else) suits Patchmanager well. I picked the latter, because it is less generic (as Qt/Qt was criticised as too generic, which is absolutely justified).

P.S.: @nephros, please note that I deliberately used "should", not "must" or "shall", because without utilising Spectacle and the Jolla Store, we are free to use or define any group; still I think it makes sense to adhere to the ones defined by Jolla, which is not hard, because the list offers lots of well defined choices.

@Olf0 Olf0 merged commit 0b27fc4 into master May 3, 2023
@Olf0 Olf0 deleted the Olf0-patch-1 branch May 3, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation documentation, Wiki and related enhancement this improves something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants