Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 88.72% 89.01% +0.29%
==========================================
Files 25 25
Lines 2066 2076 +10
==========================================
+ Hits 1833 1848 +15
+ Misses 233 228 -5 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #508, this PR adds a cli flag for updating a single album.
One key difference compared to the
ignore_directoriessetting is that this will add any albums necessary to create the breadcrumbs in the selected album, but not write them.Note that I had to adjust how the album source tree is walked to top-down mode, so it wouldn't walk the whole tree if it didn't need to. This meant changing how to ignore albums, including editing the nomedia plugin.
I also added a count of the albums processed to the stats, as that helped with debugging. I can remove that if necessary.