implement Update for OrderMap and OrderSet
#1033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
CodSpeed Performance ReportMerging #1033 will not alter performanceComparing Summary
|
oconnor663
added a commit
to astral-sh/ruff
that referenced
this pull request
Dec 4, 2025
This commit is a hack to get this branch working pending these two upstream PRs: salsa-rs/salsa#1033 bircni/get-size2#40
Veykril
reviewed
Dec 4, 2025
| hashlink = "0.10" | ||
| indexmap = "2" | ||
| intrusive-collections = "0.9.7" | ||
| ordermap = "1" |
Member
There was a problem hiding this comment.
This should be a feature gated dependency at the very least
Contributor
Author
There was a problem hiding this comment.
I was going off how indexmap was handled, but now that I look again I guess that's because it's used internally and not purely imported for trait impls. I'll put up a followup PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are places in
tywhere we needIndexMapbecause it'ssalsa::Update, and other places where we needOrderMapbecause it'sHash. @ibraheemdev has suggested that if weimpl Update for OrderMapwe could just useOrderMapacross the board.This is my first Salsa PR, so apologies for any obvious mistakes. In particular, I didn't see any tests for the existing implementations, so I haven't added any for the new ones?