Skip to content

Conversation

@s0undt3ch
Copy link
Contributor

Fixes #176

@s0undt3ch s0undt3ch requested a review from a team as a code owner March 21, 2024 11:32
@s0undt3ch s0undt3ch requested review from twangboy and removed request for a team March 21, 2024 11:32
@s0undt3ch s0undt3ch self-assigned this Mar 21, 2024
@codecov
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 85.27%. Comparing base (1ffc762) to head (2f87ee9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   85.39%   85.27%   -0.12%     
==========================================
  Files          97       97              
  Lines        5960     5977      +17     
  Branches      633      636       +3     
==========================================
+ Hits         5089     5096       +7     
- Misses        699      705       +6     
- Partials      172      176       +4     
Flag Coverage Δ
Linux 84.71% <75.87%> (-0.09%) ⬇️
Windows 76.37% <27.59%> (-0.13%) ⬇️
macOS 75.06% <27.59%> (-0.13%) ⬇️
py3.10 84.93% <75.87%> (-0.07%) ⬇️
py3.7 84.01% <74.08%> (-0.09%) ⬇️
py3.8 84.85% <75.87%> (-0.09%) ⬇️
py3.9 85.00% <75.87%> (-0.09%) ⬇️
pytest-7.3.0 ?
pytest-7.4.0 84.98% <75.87%> (-0.09%) ⬇️
pytest-8.0.0 84.31% <75.87%> (?)
pytest-8.0.0rc2 ?
pytest-8.1.0 84.31% <75.87%> (?)
salt-3005.0 ?
salt-3006.0 84.98% <75.87%> (-0.07%) ⬇️
salt-3007.0 84.80% <75.87%> (?)
src 77.28% <63.16%> (-0.07%) ⬇️
tests 96.36% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/saltfactories/plugins/__init__.py 85.72% <ø> (ø)
...integration/factories/daemons/ssh/test_salt_ssh.py 100.00% <100.00%> (ø)
...ts/integration/factories/daemons/sshd/test_sshd.py 100.00% <100.00%> (ø)
src/saltfactories/daemons/sshd.py 76.63% <63.16%> (-1.89%) ⬇️

... and 2 files with indirect coverage changes

@s0undt3ch s0undt3ch force-pushed the master branch 2 times, most recently from 90a356b to 9f5fd2d Compare March 21, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a method to get the sshd server host keys

1 participant