You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently playing around with Go on Advent of Code and found that a Product or ProductBy function would be useful, and fit in well with the preexisting Sum and SumBy functions
I think "Multiply" could be a better name, because "Product" can be related to Cartesian Product which is also a nice-to-have function
I'd argue Product is the proper name for the actual functionality here. Multiply in mind in the product of 2 numbers, rather than n numbers. Even in the lodash documentation their multiply function says it "Returns the product" (Possibly a bad naming choice they don't want to introduce a breaking change for)
How would you feel about Product for these functions and a follow-up PR with a CartesianProduct or CrossJoin (I believe this is used in other libraries) function? Both seem a bit clearer to me and better describe their respective operation
I think "Multiply" could be a better name, because "Product" can be related to Cartesian Product which is also a nice-to-have function
How would you feel about Product for these functions and a follow-up PR with a CartesianProduct or CrossJoin (I believe this is used in other libraries) function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently playing around with Go on Advent of Code and found that a Product or ProductBy function would be useful, and fit in well with the preexisting Sum and SumBy functions
Used as such:
Hope its useful!