Conversation
New Crowdin updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the
FeatureSettingsActivityto enhance maintainability, localization, and feature handling. The most significant changes include switching permission-related UI strings to use string resources for localization, utilizing a feature registry for feature metadata, and improving how feature-specific screens are handled.Localization and Internationalization:
R.string.*) instead of hardcoded text, enabling proper localization throughout the permission dialogs. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]localeConfig, further supporting app localization.Feature Handling Improvements:
FeatureRegistry, replacing the previous hardcoded map. This improves maintainability and scalability as new features are added. [1] [2]featureId) instead of the previousfeaturevariable, reducing errors and improving clarity. [1] [2] [3] [4]UI/UX Enhancements:
LinkPickerScreendemo when selected, providing a more direct and relevant user experience.Code Quality and Imports:
These changes collectively improve the app's internationalization, code maintainability, and user experience.