Fix #2877 -- Remove Deprecated SASS warnings#2889
Open
sebastiencl wants to merge 6 commits intosampotts:masterfrom
Open
Fix #2877 -- Remove Deprecated SASS warnings#2889sebastiencl wants to merge 6 commits intosampotts:masterfrom
sebastiencl wants to merge 6 commits intosampotts:masterfrom
Conversation
* fix(pkg): fix import path for ESM (fixes sampotts#2882) * fix(vimeo): hide default vimeo captions (fixes sampotts#877)
Author
|
Any PR review @sampotts ? |
Author
|
I found an issue with Vimeo videos in this version. I don't know if its due to scss or js update. I'll take a look on it later. |
Owner
|
Apologies, I've been flat out moving house. Let me know when you resolve the Vimeo issue and I'll review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to related issue (if applicable)
Fixes #2877
Summary of proposed changes
Starting from develop.
Remove deprecated sass syntax.