Add global attributes

[JoelLucaAdams]

Add the global attributes (from dataset.attrs) to a sub node titled Attributes (num_attrs) under the File Information node.

This is recursive as the attributes might contain sub dicts. This is the case in sdf-xarray as we add the simulation setup file to the attributes as a dictionary.

[samueljackson92]

Looks good, but I think this would make more sense to be under the root node (alongside Dimensions, Coordinates, Data Variables, Groups) rather than in the File info section?

[JoelLucaAdams]

Looks good, but I think this would make more sense to be under the root node (alongside Dimensions, Coordinates, Data Variables, Groups) rather than in the File info section?

The reason I placed it inside the file info node is because (at least in sdf-xarray) all global attributes came from file header information so it made sense to put it under the file info section but I'm happy to move it if you think it's more appropriate at the top level

[samueljackson92]

Not the top level, but within the root dataset node. So, at the same level as dimensions and coordinates on Root in this screenshot:

I think this makes the most sense as that is essentially where they live within the tree structure (regardless of what backend loaded those attributes)?

[JoelLucaAdams]

Yeah, in agreement with that. Sorry a bit on the tired side and this didn't quite parse through my brain right when I read it earlier. Additionally I think the attributes should be an empty node e.g. Attributes (0) if no attributes are present in case a new developer is wondering why their attributes aren't showing (see my classic blunder) although happy to simply hide the node if there are no attributes

[samueljackson92]

👍 I agree.

[JoelLucaAdams]

This is how the new attributes look and it does work nicely with nested data such as the deck setup file.

NOTE: full deck support is not currently implemented in sdf-xarray but can be quickly hardcoded (you will also need to install epydeck from uv.) by updating the open_datatree(...) at the end:

dt.attrs = ds.attrs

with open("/Users/joel/Source/sdf-xarray/docs/tutorial_dataset_2d/input.deck") as f:
    import epydeck

    dt.attrs["deck"] = epydeck.load(f)

[samueljackson92]

One minor thing: I think may attributes should be above the Groups and Data Variables not below?

[JoelLucaAdams]

Done!