Allow override of identifier_in_use lambda#86
Merged
Conversation
jcoyne
reviewed
Nov 26, 2018
| it { is_expected.to respond_to(:statefile) } | ||
| it { is_expected.to respond_to(:namespace) } | ||
| it { is_expected.to respond_to(:minter_class) } | ||
| it { is_expected.to respond_to(:identifier_in_use) } |
Member
There was a problem hiding this comment.
Isn't this a bit duplicative? You are explicitly testing this method below.
Contributor
Author
There was a problem hiding this comment.
I wouldn't normally include this, but I was following the existing pattern. Methods template and minter_class are also explicitly tested and have the respond_to test.
Contributor
Author
There was a problem hiding this comment.
Checked with @jcoyne in Slack and he gave the thumbs up to merge.
jcoyne
approved these changes
Nov 26, 2018
Member
jcoyne
left a comment
jcoyne
left a comment
There was a problem hiding this comment.
Overall seems good. I just had a minor nit to pick about testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85
Uses
||=to allow for override of identifier_in_use lambda. See issue for more information.