forked from codesquad-members-2021/java-was
-
Notifications
You must be signed in to change notification settings - Fork 0
Login-노을 #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Login-노을 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dae-Hwa
reviewed
Jul 23, 2021
Comment on lines
+115
to
+127
| private String response302Header() { | ||
| String responseMessage = "HTTP/1.1 302 Found" + System.lineSeparator() + | ||
| "Location: /index.html" + System.lineSeparator(); | ||
| return responseMessage; | ||
| } | ||
|
|
||
| private String response302HeaderWithCookie(String location, String cookie) { | ||
| String responseMessage = "HTTP/1.1 302 Found" + System.lineSeparator() + | ||
| "Location: "+location+ System.lineSeparator()+ | ||
| "Set-Cookie: "+cookie+"; Path=/"; | ||
| return responseMessage; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋네요 Header 클래스에 static 메소드 같은걸로 잡아놓아도 괜찮을 것 같습니다.
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그런데 이게 지금 단계에서만 리팩토링해야되는게 아니기 때문에(다른 부분도 함께 되야 하니까) 따로 이슈 남기고 작업해봐도 괜찮을 것 같아요
Owner
Author
|
회원가입시 로그인 처리는 미구현 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
“로그인” 메뉴를 클릭하면 http://localhost:8080/user/login.html 으로 이동해 로그인할 수 있다.
회원가입한 사용자로 로그인할 수 있어야 한다.
로그인이 성공하면 cookie를 활용해 로그인 상태를 유지할 수 있어야 한다.
로그인이 성공할 경우 요청 header의 Cookie header 값이 logined=true
로그인이 실패하면 Cookie header 값이 logined=false로 전달되어야 한다.
로그인 후에 get 요청에서 쿠키가 true로 되어야 한다.