make prodel URL conditional for global region#10879
Merged
Conversation
To make it more readable. Also, do not hard-code namespace name of `prodel` release in global region, but rather rely on values provided via `global:globals` in pipeline.
stanislav-zaprudskiy
approved these changes
Feb 26, 2026
Contributor
stanislav-zaprudskiy
left a comment
There was a problem hiding this comment.
I've pushed the update to use a named template for URL calculation to make it more readable, and also relying on global:globals values that the pipeline should supply when deploying in global region.
bbobrov
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Prodel is being deployed to the global region to support project deletion in the global Keystone domain (see cc/prodel#159).
However, Keystone's policy template currently uses a hardcoded Prodel URL that assumes the
prodelnamespace:http://prodel.prodel.svc/check-delete_project/%(project_id)sThis doesn't work for global Keystone, which runs in the
monsoon3globalnamespace and needs to call Prodel at:http://prodel.monsoon3global.svc/check-delete_project/%(project_id)sSolution
Make the Prodel URL conditional based on the
global.is_global_regionflag that's already set insecrets/global/values/globals.yaml.When
global.is_global_region=truethe URL of
prodelin the rule changes like below: