Skip to content

bump Go to 1.26, run modernize#369

Open
majewsky wants to merge 2 commits intomasterfrom
modernize-1.26
Open

bump Go to 1.26, run modernize#369
majewsky wants to merge 2 commits intomasterfrom
modernize-1.26

Conversation

@majewsky
Copy link
Contributor

@majewsky majewsky commented Feb 27, 2026

I had to run go-makefile-maker manually here. The go-m-m pipeline cannot commit this change because it then complains about the new fixable idioms, but also I cannot fix the idioms without raising the go version.

@majewsky majewsky changed the title Modernize 1.26 bump Go to 1.26, run modernize Feb 27, 2026
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/maintenance-controller/controllers 85.42% (ø)
github.com/sapcc/maintenance-controller/plugin/impl 81.41% (-0.02%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/maintenance-controller/plugin/impl/hypervisor.go 94.68% (-0.06%) 94 (-1) 89 (-1) 5 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/sapcc/maintenance-controller/controllers/node_controller_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants