Skip to content

Use lts/* and lts/-n for node version #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nex3 merged 3 commits into from
Dec 15, 2023
Merged

Use lts/* and lts/-n for node version #1957

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
430278f
Use lts/* and lts/-n for node version
ntkme Dec 14, 2023
768d285
Revert unit test to run on node 14
ntkme Dec 14, 2023
75c4dfd
Remove env.NODE_VERSION
ntkme Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 16 additions & 21 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ name: CI
defaults:
run: {shell: bash}

env:
# TODO(jathak): Update this to Node 18 once unit tests are fixed.
NODE_VERSION: 14

on:
push: {branches: [main, feature.*]}
pull_request:
Expand All @@ -18,8 +14,9 @@ jobs:

steps:
- uses: actions/checkout@v3
# TODO(jathak): Update this to 'lts/*' (the latest lts version) once unit tests are fixed.
- uses: actions/setup-node@v3
with: {node-version: "${{ env.NODE_VERSION }}"}
with: {node-version: 14}
- uses: dart-lang/setup-dart@v1
with: {sdk: stable}
- run: npm install
Expand All @@ -32,7 +29,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with: {node-version: "${{ env.NODE_VERSION }}"}
with: {node-version: 'lts/*'}
- run: npm install
- run: npm run lint

Expand All @@ -43,7 +40,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with: {node-version: "${{ env.NODE_VERSION }}"}
with: {node-version: 'lts/*'}
- run: npm install
- run: npm run lint-spec

Expand All @@ -59,7 +56,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with: {node-version: "${{ env.NODE_VERSION }}"}
with: {node-version: 'lts/*'}
- run: npm install

- uses: ./.github/util/dart-sass
Expand All @@ -69,10 +66,7 @@ jobs:

- name: Run specs
run: npm run sass-spec -- --dart dart-sass

# The versions should be kept up-to-date with the latest LTS Node releases.
# They next need to be rotated October 2021. See
# https://github.com/nodejs/Release.

js_api_dart_sass:
name: "JS API | Pure JS | Node ${{ matrix.node_version }} | ${{ matrix.os }}"
runs-on: "${{ matrix.os }}"
Expand All @@ -82,13 +76,15 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node_version: [18]
node_version: ['lts/*']
# Only test LTS versions on Ubuntu
include:
- os: ubuntu-latest
node_version: 14
node_version: lts/-1
- os: ubuntu-latest
node_version: 16
node_version: lts/-2
- os: ubuntu-latest
node_version: lts/-3

steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -136,9 +132,6 @@ jobs:
--sassSassRepo dart-sass/build/language
env: {CHROME_EXECUTABLE: chrome}

# The versions should be kept up-to-date with the latest LTS Node releases.
# They next need to be rotated October 2021. See
# https://github.com/nodejs/Release.
js_api_sass_embedded:
name: "JS API | Embedded | Node ${{ matrix.node_version }} | ${{ matrix.os }}"
runs-on: "${{ matrix.os }}"
Expand All @@ -148,13 +141,15 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node_version: [18]
node_version: ['lts/*']
# Only test LTS versions on Ubuntu
include:
- os: ubuntu-latest
node_version: 14
node_version: lts/-1
- os: ubuntu-latest
node_version: lts/-2
- os: ubuntu-latest
node_version: 16
node_version: lts/-3

steps:
- uses: actions/checkout@v3
Expand Down