Pull input text into a separate type with cached codepoint count#47
Merged
sayanarijit merged 2 commits intosayanarijit:mainfrom Apr 18, 2026
Merged
Pull input text into a separate type with cached codepoint count#47sayanarijit merged 2 commits intosayanarijit:mainfrom
sayanarijit merged 2 commits intosayanarijit:mainfrom
Conversation
Several editing or movement operations iterated the entire input string in order to count characters. It would be better to cache the count but in a way that is automatic and not subject to careful maintenance. We pull the text into a `Value` type, which only allows modifying the contained string via a guard object (`ValueMut`), which in turn derefs into the contained string. When the guard is dropped after a mutable deref, the cached character count is updated. Several operations are then optimized.
Owner
|
Thank you for the pr 👍 . Will review soon. |
Owner
|
Nice... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several editing or movement operations iterated the entire input string in order to count characters. It would be better to cache the count but in a way that is automatic and not subject to careful maintenance.
We pull the text into a
Valuetype, which only allows modifying the contained string via a guard object (ValueMut), which in turn derefs into the contained string. When the guard is dropped after a mutable deref, the cached character count is updated. Several operations are then optimized.