Skip to content

feat: new about modal#811

Merged
IRHM merged 7 commits intosbondCo:devfrom
Clusters:dev
Feb 21, 2025
Merged

feat: new about modal#811
IRHM merged 7 commits intosbondCo:devfrom
Clusters:dev

Conversation

@Clusters
Copy link
Contributor

@Clusters Clusters commented Feb 16, 2025

Screenshot 2025-02-16 180705
Screenshot 2025-02-16 181030
Image

Changes made

linked Watcharr version number in FaceMenu to releases page
added modal with about info to FaceMenu bottom
added 4 new SVG icons

closes #802

added modal with about info to FaceMenu bottom.
added 4 new SVG icons.
Copy link
Member

@IRHM IRHM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @Clusters this is great! Thank you for getting this done.

I have added a few comments which I think may improve upon the code (mostly small stuff). I don't mind doing them myself if you'd like as they are small if you agree with the notes, let me know.

Thanks!

@IRHM IRHM added the enhancement New feature or request label Feb 16, 2025
@Clusters
Copy link
Contributor Author

Thank you for the review and feedback I'll make sure to work them in 👍🏻

Clusters and others added 2 commits February 17, 2025 17:36
- moved about modal into its own file
- minor fixes
@Clusters Clusters requested a review from IRHM February 17, 2025 17:38
…ibution file link

, added a hover effect to all links in the modal and removed the margin on h5.

Also updated the top paragraph.
@IRHM
Copy link
Member

IRHM commented Feb 19, 2025

Hey @Clusters, thank you for updating the modal, it looks really great!

I made a few small changes to the modal in this commit: 0d69751

Mainly:

  • Added text to the github/website links instead of going the tooltip route.
  • Updated the main paragraph of the modal (now just explains the app, I felt weird having my name link there so I decided to rewrite it :())
  • Added a link to our attribution file (which should link to the correct version branch).

image

I don't want to force my changes on your branch (sorta did sorry), let me know what you think!

@Clusters
Copy link
Contributor Author

Hey @Clusters, thank you for updating the modal, it looks really great!

I made a few small changes to the modal in this commit: 0d69751

Mainly:

* Added text to the github/website links instead of going the tooltip route.

* Updated the main paragraph of the modal (now just explains the app, I felt weird having my name link there so I decided to rewrite it :())

* Added a link to our attribution file (which should link to the correct version branch).

image

I don't want to force my changes on your branch (sorta did sorry), let me know what you think!

looks good, I like it!

Just did I short check, everything checks out :)

Thanks!

Copy link
Member

@IRHM IRHM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your work put into this feature, I think it turned out great!

@IRHM IRHM merged commit 565d90d into sbondCo:dev Feb 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add project link to version info in user menu

2 participants