Skip to content

Fix skills build: selective reference copying prevents CLI bloat#410

Merged
sbroenne merged 7 commits intomainfrom
copilot/investigate-cli-mcp-references
Feb 3, 2026
Merged

Fix skills build: selective reference copying prevents CLI bloat#410
sbroenne merged 7 commits intomainfrom
copilot/investigate-cli-mcp-references

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026

Summary

Build script copied all 11 shared references to both CLI and MCP skills. CLI only references 3 files but received all 11, causing unnecessary package bloat.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Maintenance (dependency updates, code cleanup, etc.)

Changes Made

Build-AgentSkills.ps1: Selective copying

  • Copy only files declared in each skill's SKILL.md @references/ section
  • CLI: 3 files (behavioral-rules, anti-patterns, workflows)
  • MCP: 11 files (above + 8 excel_* guides)
  • 50% CLI package size reduction

.gitignore: Correct handling

  • Preserve skills/shared/ (source files, not generated)
  • Ignore skills/*/references/*.md (generated by build)
  • Keep skill-specific files (README.md, claude-desktop.md)

Testing Performed

  • Verified selective copying: CLI gets 3 files, MCP gets 11
  • Build produces zero warnings
  • Package contents verified via ZIP inspection

Test Commands

# Build with populated references
./scripts/Build-AgentSkills.ps1 -PopulateReferences

# Verify CLI only has 3 shared files
ls skills/excel-cli/references/

# Verify MCP has 11 shared files
ls skills/excel-mcp/references/

# Build packages
./scripts/Build-AgentSkills.ps1

# Inspect package contents
unzip -l artifacts/skills/excel-cli-skill-v*.zip | grep references/
unzip -l artifacts/skills/excel-mcp-skill-v*.zip | grep references/

Core Commands Coverage Checklist ⚠️

Does this PR add or modify Core Commands methods? [x] No

Checklist

  • Code follows project style guidelines
  • Self-review of code completed
  • Code builds with zero warnings
  • Follows Excel COM best practices from copilot-instructions.md

Additional Notes

Architecture clarification: skills/shared/ and MCP prompts (src/ExcelMcp.McpServer/Prompts/Content/) serve different purposes:

  • skills/shared/: Verbose, educational content for agent skills (all platforms)
  • MCP prompts: Concise, server-specific guidance for MCP protocol
  • Both maintained separately with intentionally different styles
  • No sync needed or wanted between them
Original prompt

We currently share references in skills for cli and mcp server. I think this leads to problems. Please investigate and evaluate and fix if needed.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 4 commits February 3, 2026 08:56
…stent pivottable reference

Co-authored-by: sbroenne <3026464+sbroenne@users.noreply.github.com>
Co-authored-by: sbroenne <3026464+sbroenne@users.noreply.github.com>
Co-authored-by: sbroenne <3026464+sbroenne@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate and evaluate shared references in CLI and MCP server Fix skills build: selective reference copying, remove broken pivottable link Feb 3, 2026
Copilot AI requested a review from sbroenne February 3, 2026 08:59
Co-authored-by: sbroenne <3026464+sbroenne@users.noreply.github.com>
Copilot AI changed the title Fix skills build: selective reference copying, remove broken pivottable link Sync MCP prompts to skills/shared and establish source of truth Feb 3, 2026
… purposes

Co-authored-by: sbroenne <3026464+sbroenne@users.noreply.github.com>
Copilot AI changed the title Sync MCP prompts to skills/shared and establish source of truth Fix skills build: selective reference copying prevents CLI bloat Feb 3, 2026
@sbroenne sbroenne marked this pull request as ready for review February 3, 2026 09:54
@sbroenne sbroenne merged commit 805963a into main Feb 3, 2026
1 check passed
@sbroenne sbroenne deleted the copilot/investigate-cli-mcp-references branch February 3, 2026 09:54
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants