Conversation
…ied (#492) Root cause: Generated dispatch uses args.Timeout ?? default(TimeSpan) = TimeSpan.Zero when timeout is omitted. Core validation threw ArgumentOutOfRangeException. Fix: Changed Core validation to use 5-minute default timeout instead of throwing. Updated interface descriptions to document the new behavior. Tests: Added 2 regression tests (ZeroTimeout, NegativeTimeout) - total 22 refresh tests pass.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix: PowerQuery Refresh Default Timeout
Fixes #492
Problem
excelcli powerquery refreshthrowsArgumentOutOfRangeExceptionwhen--timeoutis omitted, making the command unusable without explicitly specifying a timeout.Root Cause
The
ServiceRegistryGeneratorcreates nullableTimeSpan?in generated args classes. The dispatch code usesargs.Timeout ?? default(System.TimeSpan)which evaluates toTimeSpan.Zerowhen timeout is not provided. The CorePowerQueryCommands.Refresh()method validatedtimeout <= TimeSpan.Zeroand threw.Solution
Changed Core validation from throwing to using a 5-minute default timeout when
timeout <= TimeSpan.Zero. This is minimal, backwards-compatible, and matches the documented auto-timeout behavior.Files Changed:
PowerQueryCommands.Refresh.cs- Use default timeout instead of throwingIPowerQueryCommands.cs- Updated interface descriptions (2 places)PowerQueryCommandsTests.RefreshErrors.cs- Added 2 regression testsTest Coverage (22 tests, all passing)
Refresh_ZeroTimeout_UsesDefaultAndSucceeds- Regression test for the exact generated dispatch bugRefresh_NegativeTimeout_UsesDefaultAndSucceeds- Edge case validationBackwards Compatibility
Fully backwards compatible - callers providing explicit positive timeouts are unaffected.