Merged
Conversation
philippotto
approved these changes
Jun 26, 2019
Member
philippotto
left a comment
There was a problem hiding this comment.
Awesome ❤️
Also kudos for finding the unused fallbackZoomStep variable. Maybe we can paste the GLSL code into a linter to find similar occurrences?
When can we expect the new threejs release? At the end of this month?
Member
Author
I tried to find something for this but wasn't successful :/
The r106 milestone is scheduled for today, let's see :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating ThreeJS from v87 to v105 to keep up to date. Originally I wanted to profit from this change, but it seems we'll have to wait for this PR (scheduled for v106) to get non-blocking shader compilation (as well as this one). Should be easy to update, then :)
URL of deployed dev instance (used for testing):
Steps to test: