-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Labels
Description
What happened?
Looking at the code, there is not a remember option for RelayAddress.
if errOpen == nil && !c.Bool("remember") {
var rememberedOptions croc.Options
err = json.Unmarshal(b, &rememberedOptions)
if err != nil {
log.Error(err)
return
}
// update anything that isn't explicitly set
if !c.IsSet("no-local") {
crocOptions.DisableLocal = rememberedOptions.DisableLocal
}
if !c.IsSet("ports") && len(rememberedOptions.RelayPorts) > 0 {
crocOptions.RelayPorts = rememberedOptions.RelayPorts
}
if !c.IsSet("code") {
crocOptions.SharedSecret = rememberedOptions.SharedSecret
}
if !c.IsSet("pass") && rememberedOptions.RelayPassword != "" {
crocOptions.RelayPassword = rememberedOptions.RelayPassword
}
if !c.IsSet("overwrite") {
crocOptions.Overwrite = rememberedOptions.Overwrite
}
if !c.IsSet("curve") && rememberedOptions.Curve != "" {
crocOptions.Curve = rememberedOptions.Curve
}
if !c.IsSet("local") {
crocOptions.OnlyLocal = rememberedOptions.OnlyLocal
}
if !c.IsSet("hash") {
crocOptions.HashAlgorithm = rememberedOptions.HashAlgorithm
}
if !c.IsSet("git") {
crocOptions.GitIgnore = rememberedOptions.GitIgnore
}
}I am hosting my own relay so I can transfer my files on home network. I would prefer if they could all remember the relay so I wouldn't have to specify it every time.
Is there a reason why it isn't an available remembered option?
What did you expect to happen?
Passing --remember should remember the --relay flag.
Steps to reproduce
- Send file using
--rememberflag and a custom relay--relay - Do it again without the
--relayflag, will use default relay
croc version
v10.2.7
Operating System
Linux
OS Version
Arch, Ubuntu 22.04, Windows 10
Relevant log output
Additional context
No response