Unify news posts and blog posts, and standardise "authors" vs "author" in frontmatter #695
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for scientific-python-hugo-theme failed.Built without sensitive environment variables
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128; this PR adds author and date icons to news posts. @jarrodmillman suggested there were past inconsistencies in the headings, rendering, and content; which I think we have covered.
Also, there is some inconsistency in how authors are mentioned in the YAML frontmatter, which I think we should standardise:
use of
authors: ["foo"]https://github.com/search?q=%22authors%3A+%5B%22+%28org%3Ascientific-python+OR+repo%3Anumpy%2Fnumpy.org+OR+repo%3Ascipy%2Fscipy.org%29+language%3AMarkdown&type=code
use of
author: ["foo"]https://github.com/search?q=%22author%3A+%5B%22+%28org%3Ascientific-python+OR+repo%3Anumpy%2Fnumpy.org+OR+repo%3Ascipy%2Fscipy.org%29+language%3AMarkdown&type=code
This PR makes it
authors:only, which can imply either a single author or multiple authors. In that regard, I thinkauthors:is more correct, despiteauthor:being more widely used. I would like to argue that such breakage is necessary for standardisation; we are still in the v0.x cycle anyway and we have long documented the experimental nature of the theme in the user guide. Once this PR is released in v0.23, I can change all instances ofauthor:downstream.