-
Notifications
You must be signed in to change notification settings - Fork 96
Feature: experiment.EnsureControlRunsFirst() #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: experiment.EnsureControlRunsFirst() #166
Conversation
Locked mode fails on net48
|
Not sure why its got all the commits since b2ef4a3 i suspect its something to do squashing commits, the joys, will sort after this PR so i don't mess up more 😅 |
M-Zuber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation is clean, and could go in as is
I am wondering though if this actually solves the issue raised. Since sometimes I can want the experiments to run, and only then run the control. For example, if each experimental behaviour does clean up and just reports on results, then I want the control to run last, without doing any cleanup.
Which then leads us to the bikeshedding of allowing the user to optionally pass in an ordering with each behaviour, or a set number of use cases controlled by settings.
|
Legend, very nice catch, i have been very narrow focused on just the issued raised! Pass order to
|
|
|
|
See #167 and if we are happy we can close this PR? |
|
Closing in favour of #167 |
resolves #159
A new method
experiment.EnsureControlRunsFirst()which if enabled will randomise the candidates first then add the control to start.