Fix issue with mouse position when page is scrolled#1
Merged
scooterw merged 1 commit intoscooterw:fix_mouse_position_relativefrom Jul 5, 2013
Merged
Conversation
scooterw
pushed a commit
that referenced
this pull request
Jul 5, 2013
Fix issue with mouse position when page is scrolled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deals with an issue where the mouse position is off by the scroll amount when the document is scrolled.
I simply switched the scroll from being added to the client to being subtracted from the page, since we're now always using the client offset.
See Leaflet#1826
and
http://jsbin.com/etonoh/2 vs http://jsbin.com/etonoh/1