This repository was archived by the owner on Aug 9, 2024. It is now read-only.
fix: make httpGet probe port required, fix volume read_only to be camelCase#13
Merged
astromechza merged 2 commits intomainfrom Feb 22, 2024
Merged
fix: make httpGet probe port required, fix volume read_only to be camelCase#13astromechza merged 2 commits intomainfrom
astromechza merged 2 commits intomainfrom
Conversation
…elCase Signed-off-by: Ben Meier <ben.meier@humanitec.com>
…lProperties=false Signed-off-by: Ben Meier <ben.meier@humanitec.com>
astromechza
force-pushed
the
nitpicks
branch
from
d403190 to
8353019
Compare
johanneswuerbach
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some trailing issues in the beta spec and improves the validation a bit further.
containers.*.volumes.*.read_only->readOnlyto match all the other fields.containers.*.(livenessProbe|readinessProbe).httpGet.portis now required. (You can't really default this).containers.*.variablesto disallow=from environment variable namesadditionalProperties: falsetocontainers.*.volumesandcontainers.*.filesI don't expect this to cause issues in practise. I'm not aware of any examples that show the probes without a port. And we can document the fix to the read only property so that customers can fix it easily when the score implementation flags that the
read_onlyform is not supported.