Skip to content

fix(generate): clarify first-run missing score file guidance#433

Merged
mathieu-benoit merged 5 commits intoscore-spec:mainfrom
SergioChan:fix-issue-287-generate-error-msg
Apr 1, 2026
Merged

fix(generate): clarify first-run missing score file guidance#433
mathieu-benoit merged 5 commits intoscore-spec:mainfrom
SergioChan:fix-issue-287-generate-error-msg

Conversation

@SergioChan
Copy link
Copy Markdown
Contributor

Summary

  • improve the error shown when score-compose generate runs with no workloads in state
  • replace project-centric wording with explicit first-run guidance, including an example score.yaml file
  • update the related command test to match the new message

Testing

  • go test ./internal/command -run TestGenerateWithoutScoreFiles

Related

@mathieu-benoit mathieu-benoit self-requested a review April 1, 2026 21:26
Copy link
Copy Markdown
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @SergioChan, much appreciated!

Just recommended another message (the "project" aspect was the confusing part, I notice that the issue was not clear).

Otherwise, LGTM!

Signed-off-by: Mathieu Benoit <mathieu.benoit@docker.com>
Signed-off-by: Mathieu Benoit <mathieu.benoit@docker.com>
@mathieu-benoit mathieu-benoit self-requested a review April 1, 2026 21:33
Copy link
Copy Markdown
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathieu-benoit mathieu-benoit merged commit 877e824 into score-spec:main Apr 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] error message is confusing if score file not included in score-compose generate

2 participants