chore(deps): replace mitchellh/mapstructure with go-viper/mapstructure/v2#450
Conversation
|
Hi @mathieu-benoit, |
|
Hi @mathieu-benoit, |
|
@Abhishek9639, yes exactly, nothing related to what you did, I tested something and just rolled it back. No worries. Continuing my review and tests. |
…e/v2 Replace the archived mitchellh/mapstructure with the maintained go-viper/mapstructure/v2 fork and bump score-go to v1.13.0 which includes the same migration. Signed-off-by: Abhishek <abhishekup082@gmail.com>
There was a problem hiding this comment.
LGTM!
Quick diff between this new version and current latest in terms of packages with Docker Scout, all good!
- 1 packages removed
⎌ 4 packages changed (↑ 3 upgraded, ↓ 1 downgraded)
50 packages unchanged
Package Type Version Compared Version
↑ github.com/compose-spec/compose-go/v2 golang 2.10.2 2.10.1
- github.com/mitchellh/mapstructure golang 1.5.0
↑ github.com/olekukonko/tablewriter golang 1.1.4 1.1.3
↓ github.com/score-spec/score-compose golang 0.0.0-20260408004047-6fc785e66453+dirty 0.36.5
↑ github.com/score-spec/score-go golang 1.13.0 1.12.1
|
Rebased on latest main to pick up the CI fix from #452. Force-pushed to keep the branch clean. |
|
Thanks for the review |
Description
Swap out the archived
mitchellh/mapstructurefor the maintainedgo-viper/mapstructure/v2fork, and bumpscore-goto v1.13.0 which already has the same migration done.Changes:
internal/provisioners/templateprov/template.go.mitchellh/mapstructurewithgo-viper/mapstructure/v2ingo.mod.score-gofrom v1.12.1 to v1.13.0.go mod tidy.What does this PR do?
mitchellh/mapstructureis archived and no longer maintained. This replaces it with the actively maintained fork, following the plan discussed in #443 and after the same change was already merged in score-go (score-spec/score-go#176).The indirect deps (
copystructure/reflectwalk) are still pulled in throughMasterminds/sprigthat'll be handled separately as discussed in #443.Types of changes
Checklist: