feat: support ordered container start (#321)#454
feat: support ordered container start (#321)#454Abhishek9639 wants to merge 1 commit intoscore-spec:mainfrom
Conversation
|
Hi @mathieu-benoit, Quick summary of what's here:
One open point: for Let me know if anything needs adjusting. |
5640aea to
eda9cd0
Compare
eda9cd0 to
a209c16
Compare
|
Moved this back to draft while waiting for @chris-stephenson's feedback on the Also @mathieu-benoit, could you please re-assign me to this PR? I don't have write permissions to set the assignee myself. |
990584a to
add396d
Compare
|
@mathieu-benoit @chris-stephenson I've marked the PR as ready for review. |
|
Wonderful, thanks @Abhishek9639! @chris-stephenson, before merging |
Signed-off-by: Abhishek <abhishekup082@gmail.com>
add396d to
9ec8325
Compare
Description
What does this PR do?
This PR adds support for ordered container start by mapping the Score spec's
beforefield to Docker Compose'sdepends_on. When a container declaresbefore: containers: [main], the generated compose output will havemainwith adepends_onentry pointing back to that container.The
readycondition is mapped as follows:started(default) ->service_startedcomplete->service_completed_successfullyhealthy->service_healthyValidation is added during
score-compose generateto catch:For
ready: healthy, a warning is emitted if no readiness or liveness probe is defined. This keeps generation working while letting users know they may need to add a healthcheck. Waiting for @chris-stephenson's feedback on whether this should be an error instead.Uses the
score-goordered-containersbranch as instructed by @mathieu-benoit.Fixes #321
Types of changes
Checklist: