Skip to content

Change generateCmd.Flags() to use StringP for image flag #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathieu-benoit merged 3 commits into from
Apr 6, 2026
Merged

Change generateCmd.Flags() to use StringP for image flag #86

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72722a2
Change generateCmd.Flags() to use StringP for image flag
mathieu-benoit Apr 6, 2026
47ab171
Change default value of generateCmdImageFlag to empty
mathieu-benoit Apr 6, 2026
4afa310
Fix error message for missing container image
mathieu-benoit Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/command/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ var generateCmd = &cobra.Command{
slog.Info(fmt.Sprintf("Set container image for container '%s' to %s from --%s", containerName, v, generateCmdImageFlag))
workload.Containers[containerName] = container
} else {
return fmt.Errorf("failed to convert '%s' because container '%s' has no image and --image was not provided: %w", arg, containerName, err)
return fmt.Errorf("failed to convert '%s' because container '%s' has no image and --image was not provided", arg, containerName)
}
}
}
Expand Down Expand Up @@ -223,6 +223,6 @@ func init() {
generateCmd.Flags().StringP(generateCmdOutputFlag, "o", "manifests.yaml", "The output manifests file to write the manifests to")
generateCmd.Flags().String(generateCmdOverridesFileFlag, "", "An optional file of Score overrides to merge in")
generateCmd.Flags().StringArray(generateCmdOverridePropertyFlag, []string{}, "An optional set of path=key overrides to set or remove")
generateCmd.Flags().String(generateCmdImageFlag, "", "An optional container image to use for any container with image == '.'")
generateCmd.Flags().StringP(generateCmdImageFlag, "i", "", "An optional container image to use for any container with image == '.'")
rootCmd.AddCommand(generateCmd)
}
Loading