Skip to content

feature: add -n shortcut for --namespace flag in generate command#277

Merged
mathieu-benoit merged 2 commits intoscore-spec:mainfrom
YhebBOUSSELMI:feature/add-shortcut-param-for-generate-namespace
Apr 5, 2026
Merged

feature: add -n shortcut for --namespace flag in generate command#277
mathieu-benoit merged 2 commits intoscore-spec:mainfrom
YhebBOUSSELMI:feature/add-shortcut-param-for-generate-namespace

Conversation

@YhebBOUSSELMI
Copy link
Copy Markdown
Contributor

Description

Fix #275
Add -n shortcut for the --namespace flag.

What does this PR do?

Adds a -n shortcut for the --namespace flag, consistent with how other shortcuts are implemented in the project.

    # ./score-k8s generate --help
    -n, --namespace string                An optional namespace to set for all generated resources
     # Before
     ./score-k8s generate score.yaml --namespace=test-ns

    # After (shortcut added)
    ./score-k8s generate score.yaml -n test-ns 

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

Copy link
Copy Markdown
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @YhebBOUSSELMI.

Even if it was a good idea, I requested some changes to keep these other messages simple and consistent with other parameters (and I think that's what other CLIs do too).

Also, can you fix the unit tests by running them locally make test too please?

@YhebBOUSSELMI YhebBOUSSELMI force-pushed the feature/add-shortcut-param-for-generate-namespace branch from 11e2813 to be9130a Compare April 4, 2026 14:39
Copy link
Copy Markdown
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just need to fix the DCO here https://github.com/score-spec/score-k8s/pull/277/checks?check_run_id=69945366786, typically running this locally:

git rebase HEAD~2 --signoff
git push --force-with-lease origin feature/add-shortcut-param-for-generate-namespace

Other than that, this LGTM!

Yheb Bousselmi added 2 commits April 4, 2026 16:05
Signed-off-by: Yheb Bousselmi <yheb.bousselmi@partner.bmw.de>
Signed-off-by: Yheb Bousselmi <yheb.bousselmi@partner.bmw.de>
@YhebBOUSSELMI YhebBOUSSELMI force-pushed the feature/add-shortcut-param-for-generate-namespace branch from be9130a to 5f8b9e2 Compare April 4, 2026 15:05
@mathieu-benoit mathieu-benoit self-requested a review April 5, 2026 13:23
Copy link
Copy Markdown
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathieu-benoit mathieu-benoit merged commit ea5950c into score-spec:main Apr 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] Add shortcut params for generate --namespace --> generate -n

2 participants