feature: add -n shortcut for --namespace flag in generate command#277
Merged
mathieu-benoit merged 2 commits intoscore-spec:mainfrom Apr 5, 2026
Conversation
mathieu-benoit
requested changes
Apr 4, 2026
Contributor
mathieu-benoit
left a comment
There was a problem hiding this comment.
Thanks for your contribution, @YhebBOUSSELMI.
Even if it was a good idea, I requested some changes to keep these other messages simple and consistent with other parameters (and I think that's what other CLIs do too).
Also, can you fix the unit tests by running them locally make test too please?
11e2813 to
be9130a
Compare
mathieu-benoit
requested changes
Apr 4, 2026
Contributor
mathieu-benoit
left a comment
There was a problem hiding this comment.
You just need to fix the DCO here https://github.com/score-spec/score-k8s/pull/277/checks?check_run_id=69945366786, typically running this locally:
git rebase HEAD~2 --signoff
git push --force-with-lease origin feature/add-shortcut-param-for-generate-namespaceOther than that, this LGTM!
added 2 commits
April 4, 2026 16:05
Signed-off-by: Yheb Bousselmi <yheb.bousselmi@partner.bmw.de>
Signed-off-by: Yheb Bousselmi <yheb.bousselmi@partner.bmw.de>
be9130a to
5f8b9e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #275
Add
-nshortcut for the--namespaceflag.What does this PR do?
Adds a
-nshortcut for the--namespaceflag, consistent with how other shortcuts are implemented in the project.Types of changes
Checklist: