Undo ImageData texture uploads#732
Open
adroitwhiz wants to merge 1 commit intoscratchfoundation:developfrom
Open
Undo ImageData texture uploads#732adroitwhiz wants to merge 1 commit intoscratchfoundation:developfrom
adroitwhiz wants to merge 1 commit intoscratchfoundation:developfrom
Conversation
adroitwhiz
force-pushed
the
unimagedatafy
branch
from
f0823b1 to
619e99b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #731
Proposed Changes
This PR changes
texImage2Dcalls back to being passed<canvas>elements directly rather thanImageData.Reason for Changes
When uploading textures with premultiplied alpha, it's faster to pass in sources whose alpha is already premultiplied--see #731 for more detail.
Test Coverage
Should be tested manually