This repository was archived by the owner on May 21, 2021. It is now read-only.
Open
Conversation
Default to using file-based logging, but now offer a mode where everything is logged to console. Error-statements are logged to standard-error, everything else goes to standard- out.
…e seperated by newline)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to switch the logging to standard out/error logging to better support deploying a search_node in a Docker-container.
The original file-based logging is used as a default so existing deployments should not be affected.
Notice: a nearly identical PR has been made against os2display/middleware: os2display/middleware#5