This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Conversation
f2prateek
commented
Jun 14, 2018
| steps: | ||
| - checkout | ||
| - restore_cache: | ||
| key: dependency-cache-{{ checksum "package.json" }} |
Contributor
Author
There was a problem hiding this comment.
we should probably switch to yarn here at some point.
Circle CI v1 is shutting down on August 31st. This migrates the configuration to Circle 2.0. There should be no functional changes, though we should consider using yarn at some point.
f2prateek
commented
Jun 14, 2018
| - test | ||
| filters: | ||
| tags: | ||
| only: /[0-9]+(\.[0-9]+)*(-.+)?/ |
Contributor
Author
There was a problem hiding this comment.
@ccnixon @Peripheral1994 would love to get some on eyes on this part to ensure we're only deploying under two conditions (as before):
- branch is master
- version is tagged
Contributor
Author
|
cc @fathyb |
fathyb
reviewed
Jun 14, 2018
| jobs: | ||
| test: | ||
| docker: | ||
| - image: circleci/node:4-browsers |
Contributor
There was a problem hiding this comment.
Node.js 4 has been dropped and 6 is in maintenance since April. We should consider upgrading to 8 (current LTS).
Contributor
Author
There was a problem hiding this comment.
Yes absolutely! I wanted to avoiding changing too much in this PR, but I think that's a great point. I'll make a ticket for this in the backlog.
f2prateek
added a commit
that referenced
this pull request
Jun 15, 2018
This slipped through in the previous PR (#77).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Circle CI v1 is shutting down on August 31st. This migrates the configuration to Circle 2.0.
There should be no functional changes.