Implemented Bookmarks Feature#304
Conversation
Implemented the bookmarks and update on click in the overview table Updated the bookmarkResult function to use a number instead of a string to allow for easier id comparisons, and udpated the notice on update
This initialization of the state as an empty list is what is done in the list page and also helps prevent potential undefined errors in the page
|
@leonjza when you get a moment, could you take a look at this? Thanks! |
|
hi, This looks awesome! Is there any way this could instead be made into a tag system? I feel like making a general tagging system and then making bookmarks a particular tag might be even more useful down the line. |
|
@Polochon-street do you mean some system where the bookmark is a string value tag that can be specified for each screenshot you tag and then you can filter by tags? The backend implementation would be straightforward, it would more so be the UI changes that could be clunky as you would need to add a drop down text search for the tags on the gallery view and then slightly in the filtering section. |
|
exactly! To begin with everything UI-wise could be kept as-is - bookmarking a tab would be associating the URL with a tag "bookmarked" (or equivalent), and filtering would simply be filtering by tag "bookmarked". Would that work? :) |
|
Hey @daylamtayari, this looks pretty good, thanks! I'm still getting back in the swing of things and will do a more thorough review / test when I get some free cycles. Appreciate the work! |
|
@leonjza sounds good, thanks! When you do take a more in depth look at it, also let me know if you'd prefer for it to be kept as is or turned into a |
|
Hi @leonjza just wanted to follow up if you've had a chance to take a look at this? Thanks! |
3 participants
Summary
Added a bookmarking feature and implemented it across the API, UI, and CLI. Allows user to bookmark a given result and then view and filter their results by bookmarks.
Implementation Specifics
Model
API
Web Components
Web UI
CLI
Related Issues
The following are issues requesting this feature:
Screenshots