Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #626 +/- ##
==========================================
- Coverage 99.47% 99.41% -0.05%
==========================================
Files 15 15
Lines 3347 3351 +4
Branches 446 446
==========================================
+ Hits 3329 3331 +2
- Misses 12 14 +2
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| except AttributeError: | ||
| trapezoid_function = numpy.trapz |
There was a problem hiding this comment.
Can we add a unit-test (probably with patching or removing numpy.trapezoid)?
There was a problem hiding this comment.
It's not straightforward, different versions of numpy behave inconsistently; some have both methods while others have only one. We might work on this later to increase coverage.
| if isinstance(area, numpy.memmap): | ||
| area = area.dtype.type(area) |
There was a problem hiding this comment.
I know this might be out-of-scope for this PR, but if we can trigger this line in unit-test that's also good (only if it's easy-fix).
There was a problem hiding this comment.
I don't have any idea why the check for numpy.memmap was added here.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
numpy.trapzdeprecation bug fixedAny other comments?