Skip to content

Comments

Fix na interpretation#627

Merged
sepandhaghighi merged 5 commits intosepandhaghighi:devfrom
fhausmann:fix_na_interpretation
Jan 30, 2026
Merged

Fix na interpretation#627
sepandhaghighi merged 5 commits intosepandhaghighi:devfrom
fhausmann:fix_na_interpretation

Conversation

@fhausmann
Copy link

Reference Issues/PRs

#575

What does this implement/fix? Explain your changes.

This adds a check for NaN values for all interpretation values, reporting None instead of good values explicitly.

Any other comments?

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.41%. Comparing base (66d75bb) to head (272bd5a).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #627      +/-   ##
==========================================
+ Coverage   99.41%   99.41%   +0.01%     
==========================================
  Files          15       15              
  Lines        3351     3380      +29     
  Branches      446      460      +14     
==========================================
+ Hits         3331     3360      +29     
  Misses         14       14              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sepandhaghighi sepandhaghighi added the bug Something isn't working label Jan 8, 2026
@sepandhaghighi sepandhaghighi added this to the PYCM v4.6 milestone Jan 8, 2026
Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @fhausmann

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sepandhaghighi sepandhaghighi merged commit a231e41 into sepandhaghighi:dev Jan 30, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants