Skip to content

fix: make windows-arm64 build#698

Merged
sagudev merged 9 commits intoservo:mainfrom
burhankhanzada:windows-arm64
Jan 17, 2026
Merged

fix: make windows-arm64 build#698
sagudev merged 9 commits intoservo:mainfrom
burhankhanzada:windows-arm64

Conversation

@burhankhanzada
Copy link
Contributor

  • enable aarch64 on windows on arm

@burhankhanzada
Copy link
Contributor Author

@jdm can you approve it or there is some reason not to support windows-arm64 build currently.

@sagudev
Copy link
Member

sagudev commented Jan 17, 2026

also needs mozjs-sys bump to 0.140.5-8 so it will publish new artifacts

@burhankhanzada
Copy link
Contributor Author

also needs mozjs-sys bump to 0.140.5-8 so it will publish new artifacts

how about first make sure this ci changes works then update the version in new PR

@burhankhanzada burhankhanzada force-pushed the windows-arm64 branch 4 times, most recently from add2bb0 to d2897ba Compare January 17, 2026 13:12
@burhankhanzada
Copy link
Contributor Author

@burhankhanzada
Copy link
Contributor Author

burhankhanzada commented Jan 17, 2026

@sagudev do you know why its not showing any log for https://github.com/servo/mozjs/actions/runs/21094818107/job/60671635602?pr=698#logs

never mind i made a typo for os name

@sagudev
Copy link
Member

sagudev commented Jan 17, 2026

you also need to bump mozjs version er else CI will not be happy

@burhankhanzada burhankhanzada force-pushed the windows-arm64 branch 2 times, most recently from feed5b8 to a07fd1d Compare January 17, 2026 14:58
Copy link
Member

@sagudev sagudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

burhankhanzada and others added 9 commits January 17, 2026 16:10
Signed-off-by: Burhan Khanzada <burhan.khanzada@slint.dev>
Signed-off-by: Burhan Khanzada <burhankhanzada199888@gmail.com>
Signed-off-by: Burhan Khanzada <burhankhanzada199888@gmail.com>
Signed-off-by: Burhan Khanzada <burhankhanzada199888@gmail.com>
Signed-off-by: Burhan Khanzada <burhankhanzada199888@gmail.com>
Signed-off-by: Burhan Khanzada <burhankhanzada199888@gmail.com>
Signed-off-by: Burhan Khanzada <burhankhanzada199888@gmail.com>
Signed-off-by: Burhan Khanzada <burhankhanzada199888@gmail.com>
Signed-off-by: Burhan Khanzada <burhankhanzada199888@gmail.com>
Signed-off-by: Burhan Khanzada <burhankhanzada199888@gmail.com>
@sagudev sagudev added this pull request to the merge queue Jan 17, 2026
Merged via the queue into servo:main with commit 78f08ed Jan 17, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants