(#28) fix: incorrect version display in Homebrew installation#29
Merged
(#28) fix: incorrect version display in Homebrew installation#29
Conversation
Fix version detection to work correctly in Homebrew installations: - Add VERSION file for explicit version tracking - Modify bin/mac-ops to check .git existence before using git describe - Fallback to VERSION file when .git is absent (Homebrew install) - Update release workflow to inject VERSION file into tarball This prevents git describe from finding parent Homebrew repo (v5.0.14) and displaying wrong version in Homebrew installations. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Homebrew installation shows incorrect version (v5.0.14 instead of v1.2.0).
Root cause:
git describesearches parent directories when .git is absent, finding Homebrew's own git repository.Solution
✅ Add VERSION file for explicit version tracking
✅ Check .git existence before using git describe
✅ Fallback to VERSION file in Homebrew installations
✅ Inject VERSION file into release tarball
Changes
Testing
Closes #28
🤖 Generated with Claude Code