Skip to content

Add scripts for building CMake files#344

Merged
Yael-X merged 11 commits intosgl-project:mainfrom
1329009851:sgl-cmake2
Jan 29, 2026
Merged

Add scripts for building CMake files#344
Yael-X merged 11 commits intosgl-project:mainfrom
1329009851:sgl-cmake2

Conversation

@1329009851
Copy link
Contributor

Delete the CMake files and add some scripts for building CMake files

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @1329009851, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on automating and improving the CMake build process for the deepep module, particularly concerning operator compilation for Ascend platforms. It introduces new scripts for building CMake files, integrates CANN library detection, and modifies the build process to accommodate custom operators. The changes aim to streamline the build process and ensure compatibility with different environments.

Highlights

  • CMake Build Scripts: This PR introduces new and modifies existing shell scripts to facilitate the building of CMake files for the deepep module.
  • Operator Compilation: The changes include scripts to compile custom operators (ops) for Ascend platforms, focusing on the deepep module.
  • CANN Integration: The CMakeLists.txt files are updated to detect and utilize CANN (Compute Architecture for Neural Networks) installations, ensuring compatibility with different CANN versions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new 'deepep' module with custom operators and build scripts. It includes changes to 'build.sh' to create a deepep cmake, a new 'csrc/build.sh' script, 'AddCustom.json' describing the custom operator, 'deepep/build.sh' for building the module, 'compile_ascend_proj.sh' for compiling Ascend projects, and updates to 'ops/CMakeLists.txt' and 'ops2/CMakeLists.txt' to handle CANN versions. Review comments suggest adding a newline to the end of certain files, removing redundant CANN version checks in 'CMakeLists.txt', and making the SOC version configurable in 'deepep/build.sh'.

@1329009851
Copy link
Contributor Author

The compilation verification is performed in the cann8.2, cann8.2, and cann8.5 versions, and the test is passed successfully.

@1329009851
Copy link
Contributor Author

1329009851 commented Jan 26, 2026

The file changes displayed by git status before and after the build of cann8.2, 8.3, and 8.5 are as follows:

before

Untracked files:
.github/
.gitignore
.pre-commit-config.yaml

after

Changes not staged for commit:
modified: csrc/deepep/ops/op_kernel/moe_distribute_base.h

Untracked files:
.github/
.gitignore
.pre-commit-config.yaml

After the build, the moe_distribute_base.h file is updated. The cause of this issue will be located later.

@Yael-X Yael-X merged commit c5fe896 into sgl-project:main Jan 29, 2026
4 checks passed
1329009851 added a commit to 1329009851/sgl-kernel-npu that referenced this pull request Jan 29, 2026
Yael-X pushed a commit that referenced this pull request Jan 29, 2026
1329009851 added a commit to 1329009851/sgl-kernel-npu that referenced this pull request Feb 11, 2026
…-npu into sgl-cmake2

* 'sgl-cmake2' of https://github.com/1329009851/sgl-kernel-npu:
  CI execution requirements for separating a2 and a3 (sgl-project#367)
  Fix the bug that total expert num greater than 256 or local expert num is less than 8 (sgl-project#364)
  adapt ant moving to A2 single machine (sgl-project#362)
  reset ci -- run test mixed running for experts on a2. (sgl-project#365)
  Revert "Build the deepep package with the chip model included. (sgl-project#274)" (sgl-project#363)
  fix:buffer control (sgl-project#361)
  Build the deepep package with the chip model included. (sgl-project#274)
  bugfix wrong packages build dir (sgl-project#360)
  bump version to 2026.02.01 (sgl-project#359)
  Cover the workflows cases on a3 (sgl-project#321)
  release follows naming convention (sgl-project#356)
  Modify notifydispatch to support DEEPEP_NORMAL_LONG_SEQ_ROUND up to 128. (sgl-project#352)
  fix the hanging bug (sgl-project#355)
  [Bugfix] Fix build script working with cann 8.5.0 (sgl-project#354)
  Modify the description of DeepEP in the README file. (sgl-project#348)
  Revert "Add scripts for building CMake files (sgl-project#344)" (sgl-project#353)
  Add scripts for building CMake files (sgl-project#344)
  Support x86_64 and aarch64 binary release (sgl-project#325)
  add function for deep-ep tests (sgl-project#301)
  [Doc] Improved README.md content and English grammar and integrated the DeepWiki badge for Ask AI (sgl-project#345)
zzx-study pushed a commit to zzx-study/sgl-kernel-npu that referenced this pull request Feb 28, 2026
* Add scripts for building CMake files

* changes from pre-commit

* changes from pre-commit

* Modifying File Permissions

* Changing the script file name

* Modifying Script Permissions

* Fix a script call bug

* Fix a script call bug

* Update build.sh
zzx-study pushed a commit to zzx-study/sgl-kernel-npu that referenced this pull request Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants