-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
Description
Currently, most of the run-ci label checking is done via static checks in each workflow, for example:
sglang/.github/workflows/pr-test-rust.yml
Line 75 in 890368c
| if: github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'run-ci') |
This approach has some drawbacks:
- After we disable the
labeledtrigger for CI workflows, adding a newrun-cilabel to a PR no longer updates the PR info for existing runs. To pick up the new label, we have to push a new commit. Using the “Re-run” button alone keeps the old (outdated) PR info. - Other backends’ CI workflows cannot easily reuse the same fine-grained PR gate logic.
To resolve this, we’d like each CI to reuse the shared logic in ./.github/workflows/pr-gate.yml and align their trigger rules with it.
The inputs of pr-gate can be defined with #13491
Progress:
- CUDA CI ([CI] fix triggered by a non-run-ci label #13393)
- AMD CI ([CI] fix triggered by a non-run-ci label #13393)
- Rust / Router CI @slin1237
- XPU CI ([CI] apply pr-gate for XPU #13663)
- XEON CI @ZailiWang
- NPU CI ([NPU] Adapt pr-gate for pr-test workflow & workflows refresh #13567) @iforgetmyname
Better CI failure panel:
- Avoid any direct checking
run-cilabel in all workflows (the label would not be updated when retriggering) - Add
pr-gateinto the finish check's needs.
Reactions are currently unavailable