Skip to content

[Feature] Apply pr-gate for all backend's CIs #13436

@hnyls2002

Description

@hnyls2002

Currently, most of the run-ci label checking is done via static checks in each workflow, for example:

if: github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'run-ci')

This approach has some drawbacks:

  • After we disable the labeled trigger for CI workflows, adding a new run-ci label to a PR no longer updates the PR info for existing runs. To pick up the new label, we have to push a new commit. Using the “Re-run” button alone keeps the old (outdated) PR info.
  • Other backends’ CI workflows cannot easily reuse the same fine-grained PR gate logic.

To resolve this, we’d like each CI to reuse the shared logic in ./.github/workflows/pr-gate.yml and align their trigger rules with it.

The inputs of pr-gate can be defined with #13491

Progress:

Better CI failure panel:

  • Avoid any direct checking run-ci label in all workflows (the label would not be updated when retriggering)
  • Add pr-gate into the finish check's needs.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions