[router] fix chat template loading and tokenizer path#10999
Conversation
Summary of ChangesHello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the tokenizer loading mechanism, particularly for models that utilize chat templates. It addresses the diverse ways Hugging Face models store their chat templates and tokenizer configurations, ensuring the router can reliably discover and apply the correct template. The changes also improve the robustness of identifying the core tokenizer files within complex cache structures, leading to more consistent and accurate model initialization. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces significant improvements to tokenizer and chat template loading, particularly for models from Hugging Face. The changes include a more robust discovery mechanism for chat templates with a clear priority order, and better handling of different HF cache directory structures. The addition of extensive integration tests for various models is a great step towards ensuring correctness. My review focuses on a few areas for improvement: reducing code duplication in the template discovery logic, addressing potential panics from unsafe unwraps, fixing a potential logic issue in path resolution, and making the new integration tests more robust in a CI environment.

Checklist