convert test_deterministic into unit tests#11095
Merged
Fridge003 merged 10 commits intosgl-project:mainfrom Oct 7, 2025
Merged
convert test_deterministic into unit tests#11095Fridge003 merged 10 commits intosgl-project:mainfrom
Fridge003 merged 10 commits intosgl-project:mainfrom
Conversation
Signed-off-by: Alex Chi Z <iskyzh@gmail.com>
Signed-off-by: Alex Chi Z <iskyzh@gmail.com>
Signed-off-by: Alex Chi Z <iskyzh@gmail.com>
Fridge003
reviewed
Sep 30, 2025
This was referenced Sep 30, 2025
Contributor
Collaborator
Fixed |
ch-tiger1
pushed a commit
to ch-tiger1/sglang
that referenced
this pull request
Oct 9, 2025
Signed-off-by: Alex Chi Z <iskyzh@gmail.com> Co-authored-by: Baizhou Zhang <sobereddiezhang@gmail.com>
Contributor
Author
|
Thanks for following up :) Did not have my personal laptop with me last week 😂 |
lpc0220
pushed a commit
to lpc0220/sglang
that referenced
this pull request
Oct 29, 2025
Signed-off-by: Alex Chi Z <iskyzh@gmail.com> Co-authored-by: Baizhou Zhang <sobereddiezhang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part of #10278
Modifications
The patch converts the deterministic test into unit tests so that it's easier to detect issues in CI and avoid regression.
n_startparameter so that we can start with 10+ size batch, saving some timeAccuracy Tests
Benchmarking and Profiling
Checklist